Use option index as row tag value in SelectorViewController

[rayx]

When using PushRow with custom type, if two instances of the custom type have same string representation, it would crash the App due to "Duplicate tag" error (see #552). As the author commented in that issue, the preferred method is to modify the custom type's description computed property to generate different string for different instance. However, that's not always feasible, given that the same string is also used as the text shown to user (meaning: one can't dump everything that helps to differentiate two instances in the string). In those (rare) cases, I think it's better to show those options with same text rather than crash the App. As far as I can tell, the only thing prevents that behavior is the tags generated in the code. The commit fixes that by making sure tags are unique.

[rayx]

@mats-claassen Could you please take a look at the new patch? The CI build failed. But from what I can tell, it didn't seem to have anything to do with my change (I tested the change in my own repo). Thanks.

[mats-claassen]

It seems the unit tests failed. If you select the Eureka target scheme you can run them and see why they failed

[rayx]

Thanks for the notification. I'm tied up with my project and won't be able to try it soon. Will look into it when I get a chance (perhaps in June).

[aPandeyisystango]

When I am using this piece of code and get rid of duplicate tag error.

[rayx]

@aPandeyisystango I'm not sure what exact issue you ran into. I included the patch in one of my apps and it worked well. If you look at the code change, there is no reason why it could fail. Are you sure the issue you hit was the same issue the patch addressed? Anyway I haven't done iOS app development for a few months and probably won't do it any time soon, so I'm afraid I can't help on this.