-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cocoapods integration #91
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* wip: does not build yet, no progress on subscribe needs AsyncIterator * fix: some tests pass, subscribe still not implemented * feat: initialize rust client outside of GRPCApiClient * feat: partial integration of newest Rust<>Swift bindings * feat: implement polling subscribe * test: add test for content in testStreamingMessagesFromV2Conversations * feat: working if you comment out NotificationService logic * Get tests building again * Cleanups * Format * Ignore pods * Updates * Update package.resolved * Fix lint * Fix more lint * update pod * Bump XMTPRust version * Get example app building again * Move everything to cocoapods * Get rid of cocoapods for the example app * Try to get XMTP buildable for testing * Fix test building * wip: tests seemed to pass * fix: reset the cocoapod * fix: tests pass with new paging info changes, removed some printlns, need to address QueryResponse ownership * fix: upgrade to XMTPRust=0.2.2-beta0 to attempt to fix Package.resolved issue in Xcode cloud * fix: delete Package.resolved from xcshareddata * fix: attempt to use Package.resolved from a passing commit * fix: open Example app and let swift re-resolve * fix: use package.resolved after running example app successfully * fix: try to undo changes to XMTP.xcscheme --------- Co-authored-by: Michael Xu <[email protected]>
michaelx11
force-pushed
the
cocoapods-integration
branch
from
May 11, 2023 00:51
e2776e7
to
25353ef
Compare
* feat: remove proto Package.swift dependency * fix: try a pod install
…n not available in pods (#102) * fix: re-introduce 16.0 restriction * fix: passes pod lint now
@nakajima - thoughts on the Example app? I think it's half-configured for Cocoapods and half-configured for Swift Package Manager. I get redefinition errors unless I nuke all the pods in the Podfile. |
nplasterer
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Issue: xmtp/xmtp-react-native-old#10
This PR represents the changes needed to package xmtp-ios into an XMTP cocoapod.
The major changes are:
Diagram
See https://github.com/xmtp/xmtp-rust-swift#diagram
Releases
From this branch we've released:
query
and therefore only returns the first 100 elements of a queryquery
and has working streaming.Tests