XEP-0198: Add section defining SASL2 and BIND2 interaction #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as per XSF room discussion on September 11
iNPUTmice
force-pushed
the
smacks_inline
branch
from
78172cc to
f90ca5c
Compare
ge0rg
reviewed
Sep 21, 2023
xep-0198.xml
Outdated
| <section1 topic='Security Considerations' anchor='security'> | ||
| <p>As noted, a server MUST NOT allow a client to resume a stream management session until after the client has authenticated (for some value of "authentication"); this helps to prevent session hijacking.</p> | ||
| <p>If SASL2 is used to inline stream resumption implementations must adhere to the security considerations defined in &xep0388; regarding the inclusion of SASL2 requests and inline feature negotiation in TLS 0-RTT ("early data") extensions. That is, they MUST NOT be sent or processed if the stream would be resumed solely based on 0-RTT data, except when appropriate mitigations are in place (which are beyond the scope of this document, but may be defined by others).</p> |
There was a problem hiding this comment.
editorial:
- missing comma after "inline stream resumption"
- the "they" in the second sentence is ambiguous, please replace with "these elements"
|
Council has accepted this today. |
|
Council may have accepted it, but the build seems to be failing :) |
|
@Kev What exactly is failing the build? Or to rephrase it: what has to be changed/fixed to make it build? |
This reverts commit f90ca5c.
|
Our tooling can’t handle when multiple XEPs are in the same PR. Please also merge #1303 (this has council approval. It's just a split of the old PR) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #1215 but changes the inline feature element name to
smto match what is currently in the wild. (And to match the example)This PR also changes the (non normative) example in XEP-0388