Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: improve iteration over multiple changed files #1378

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

CI: improve iteration over multiple changed files #1378

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/xep-validation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,12 @@ jobs:

- name: Validate changed file(s)
if: steps.changed-xeps.outputs.any_changed == 'true'
env:
ALL_CHANGED_FILES: ${{ steps.changed-xeps.outputs.all_changed_files }}
run: |
sudo apt-get install -y libxml2-utils
result=0
for xep in "${{ steps.changed-xeps.outputs.all_changed_files }}"; do
for xep in ${ALL_CHANGED_FILES}; do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you could make this change simpler just by removing the quotes here (untested):

Suggested change
for xep in ${ALL_CHANGED_FILES}; do
for xep in ${{ steps.changed-xeps.outputs.all_changed_files }}; do

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... possibly, but I definitely tested the commit as-is, and I don't think the proposed modification makes things considerably more easy. I'm happy to go with the commit as-is, unless someone feels strongly about this and wants to test the alternative.

if ! tools/validate-xep0001-conformance.sh "$xep"; then
result=1
fi
Expand Down