Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XEP-0001: Make only editorial changes affect Deferred state #780

Merged
merged 2 commits into from
Mar 11, 2024
Merged

XEP-0001: Make only editorial changes affect Deferred state #780

merged 2 commits into from
Mar 11, 2024

Conversation

horazont
Copy link
Contributor

@horazont horazont commented Apr 6, 2019

@horazont horazont added the Needs Board The affected XEP has the Board as Approving Body and it needs to decide on the change. label Apr 6, 2019
@horazont horazont self-assigned this Apr 6, 2019
@guusdk guusdk requested review from guusdk, mwild1, Nyco, ralphm and SeveFP April 8, 2019 09:33
Kev
Kev reviewed Apr 8, 2019
View reviewed changes
xep-0001.xml Outdated Show resolved Hide resolved
SeveFP
SeveFP suggested changes Apr 9, 2019
View reviewed changes
xep-0001.xml Outdated Show resolved Hide resolved
@ralphm ralphm added the Needs Council The affected XEP has the Council as Approving Body and it needs to decide on the change. label Apr 25, 2019
@iNPUTmice
Copy link
Contributor

Council has accepted this.

@Kev
Copy link
Member

Kev commented Jul 19, 2023

Council has accepted this.

Thanks @iNPUTmice - was that with our without my suggested text?

@iNPUTmice
Copy link
Contributor

We voted on the PR as is. (Without your comment; which tbh I didn’t see)

@ralphm
Copy link
Member

ralphm commented Jul 20, 2023 •
edited
Loading

If @Kev is ok with this change without his suggestion, then please resolve that conversation.

@iNPUTmice @Kev
Update xep-0001.xml
817252e 
Co-authored-by: Kevin Smith <[email protected]>
@iNPUTmice iNPUTmice merged commit 2381ca0 into xsf:master Mar 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kev Kev Kev left review comments

@lnjX lnjX lnjX left review comments

@SeveFP SeveFP SeveFP requested changes

@guusdk guusdk guusdk approved these changes

@mwild1 mwild1 Awaiting requested review from mwild1

@Nyco Nyco Awaiting requested review from Nyco

@ralphm ralphm Awaiting requested review from ralphm

Assignees

@horazont horazont

Labels
Needs Board The affected XEP has the Board as Approving Body and it needs to decide on the change. Needs Council The affected XEP has the Council as Approving Body and it needs to decide on the change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@horazont @iNPUTmice @Kev @ralphm @guusdk @lnjX @SeveFP