CRISTAL-444: And error message is presented to the user when starting…

… electron with default parameters
xwiki-contrib · Jan 30, 2025 · 8351286 · 8351286
1 parent 4b3d85b
commit 8351286
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 2 deletions.
diff --git a/electron/.electron-builder.config.js b/electron/.electron-builder.config.js
@@ -61,5 +61,6 @@ module.exports = async function () {
       executableName: "cristal",
       target: "nsis",
     },
+    afterPack: "electron-builder-sandbox-fix",
   };
 };
diff --git a/electron/main/src/index.ts b/electron/main/src/index.ts
@@ -127,5 +127,3 @@ if (import.meta.env.PROD) {
     )
     .catch((e) => console.error("Failed check and install updates:", e));
 }
-
-app.commandLine.appendSwitch("--no-sandbox");
diff --git a/electron/package.json b/electron/package.json
@@ -29,6 +29,7 @@
   "devDependencies": {
     "electron": "34.0.1",
     "electron-builder": "25.1.8",
+    "electron-builder-sandbox-fix": "1.0.11",
     "typescript": "5.7.3",
     "vite": "6.0.11"
   }

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
-Original file line number
+Diff line change
@@ Expand Up / @@ -127,5 +127,3 @@ if (import.meta.env.PROD) { @@
         )
         .catch((e) => console.error("Failed check and install updates:", e));
     }
-    app.commandLine.appendSwitch("--no-sandbox");