Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRISTAL-408: We don't check if a page already exists on page creation #580

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pjeanjean
Copy link
Contributor

Jira URL

https://jira.xwiki.org/browse/CRISTAL-408

Changes

Description

This adds an alert in the page creation dialog if the page already exists, with an action to edit it instead.

Clarifications

N/A

Screenshots & Video

image

Executed Tests

The UI tests were run locally.

Expected merging strategy

  • Prefers squash: Yes
  • Backport on branches:
    • N/A

var locationReference: SpaceReference | undefined = undefined;
var newDocumentReference: string = "";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
var newDocumentReference: string = "";
let newDocumentReference: string = "";

@@ -141,6 +176,13 @@ function createPage() {
</template>

<style scoped>
#new-page-alerts-wrapper {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think using classes would be better than ids here, unless there is a reason?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants