Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRISTAL-423: Odd alignment of the border on AttachmentUploadForm component #593

Merged
merged 1 commit into from
Jan 20, 2025
Merged

CRISTAL-423: Odd alignment of the border on AttachmentUploadForm component #593

merged 1 commit into from
Jan 20, 2025
+6 −0

Conversation

tkrieck
Copy link
Collaborator

@tkrieck tkrieck commented Jan 17, 2025

Jira URL

https://jira.xwiki.org/projects/CRISTAL/issues/CRISTAL-423

Changes

Description

  • On Shoelace, there's an alignment problem on the border of the uploadForm component. This PR fixes this small issue

Clarifications

  • Shoelace does not have a custom component like Vuetify so both are a bit different handling this.

Screenshots & Video

Before:
image

After:
Screenshot 2025-01-17 at 13 38 20

Executed Tests

Expected merging strategy

  • Prefers squash: Yes
  • Backport on branches:
    • N/A

@manuelleduc manuelleduc merged commit 90de6ee into main Jan 20, 2025
4 of 5 checks passed
@manuelleduc manuelleduc deleted the CRISTAL-423 branch January 20, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@manuelleduc manuelleduc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tkrieck @manuelleduc