Version correct

yairm210 · Jul 28, 2024 · 444fbe0 · 444fbe0
1 parent 21a5f94
commit 444fbe0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml
@@ -28,7 +28,7 @@ jobs:
         run: dotnet tool install --global wix
 
       - name: Build WiX on Windows
-        run: |
+        run: | # Trying to set env variables for a simple command is like ???, now I truly understand the "Windows Sucks" mentality
           cmd /C "set UNCIV_VERSION=4.12.14 && wix build .\unciv.wxs"
           dir
         

diff --git a/unciv.wxs b/unciv.wxs
@@ -5,8 +5,9 @@
     <Package Language="1033"
              Manufacturer="Yair Morgenstern"
              Name="$(var.Name)"
-             Version="$(env.UNCIV_VERSION)"
+             Version="$(env.UNCIV_VERSION).0"
             UpgradeCode="74d42802-054a-4869-a703-658c361fe94c">
+             <!-- MSI versions require a 4-part, so we add a ".0" to the end of every version -->
         <Icon Id="icon.ico" SourceFile="files/Unciv.ico"/>
         <MajorUpgrade DowngradeErrorMessage="A newer version of [ProductName] is already installed." Schedule="afterInstallInitialize" />