Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dropdownToggle): Prevent dropdown from closing automatically #123

Closed
wants to merge 22 commits into from
Closed

feat(dropdownToggle): Prevent dropdown from closing automatically #123

wants to merge 22 commits into from

Conversation

hainp2604
Copy link

Hi,

Foundation has 'content' dropdown which won't be closed when we click on it. So, I come up with a solution for #119.

@jbrowning
Copy link
Member

Thanks for your contribution @hainp. Instead of checking for the content class, which could easily collide with user-defined classes, I'd rather configure this via an attribute on the dropdownToggle directive.

@drasill
Copy link

drasill commented Oct 8, 2014

Foundation has 'content' dropdown which won't be closed when we click on it.

As I see on http://foundation.zurb.com/docs/components/dropdown.html, the "content" dropdown is just a style :

content: Add padding inside the dropdown for better-looking content

Also on this page, every dropdown on the page is kept open on click.

Shouldn't angular-foundation do the same ?

@hainp2604
Copy link
Author

@jbrowning: Oh, my bad, I still have 'jQuery' in my head when writing the code. I should go the attribute-way :)

@drasill : I made wrong assumption about 'content' dropdown.

@jbrowning
Copy link
Member

@drasill the goal of this project is to provide Angular components for Foundation CSS, not necessarily to replicate the behavior of Foundation's vanilla JS components.

@hainp make it so 😉

@itonics-tbeauvais
Copy link

This is rather old, is this going to be pulled anytime soon?

@ghost
Copy link

ghost commented Mar 23, 2015

I find that this does not work, on chrome... Unless you replace the line:

if (dropdown.attr('show-on-click')) {

with:

if (dropdown.attr('show-on-click') != null) {

@hainp2604 hainp2604 closed this Mar 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants