Skip to content

Commit

Permalink
Reviewer comments
Browse files Browse the repository at this point in the history
  • Loading branch information
yashykt committed Oct 17, 2024
1 parent 17f1187 commit 0bfe91d
Show file tree
Hide file tree
Showing 6 changed files with 175 additions and 169 deletions.
4 changes: 2 additions & 2 deletions src/core/ext/transport/binder/server/binder_server.cc
Original file line number Diff line number Diff line change
Expand Up @@ -155,10 +155,10 @@ class BinderServerListener : public Server::ListenerInterface {
return nullptr;
}

void SetServerListenerWrapper(Server::ListenerWrapper*) override {}
void SetServerListenerState(Server::ListenerState*) override {}

const grpc_resolved_address* resolved_address() const override {
// binder doesn't use the new ListenerWrapper interface yet.
// binder doesn't use the new ListenerState interface yet.
Crash("Unimplemented");
return nullptr;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -132,10 +132,10 @@ class ChaoticGoodServerListener final : public Server::ListenerInterface {
return nullptr;
}

void SetServerListenerWrapper(Server::ListenerWrapper*) override {}
void SetServerListenerState(Server::ListenerState*) override {}

const grpc_resolved_address* resolved_address() const override {
// chaotic good doesn't use the new ListenerWrapper interface yet.
// chaotic good doesn't use the new ListenerState interface yet.
Crash("Unimplemented");
return nullptr;
}
Expand Down
Loading

0 comments on commit 0bfe91d

Please sign in to comment.