Reviewer comments

yashykt · Jan 28, 2025 · 97fcd80 · 97fcd80
1 parent b758bde
commit 97fcd80
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/test/cpp/end2end/xds/xds_end2end_test_lib.cc b/test/cpp/end2end/xds/xds_end2end_test_lib.cc
@@ -381,7 +381,8 @@ const char XdsEnd2endTest::kRequestMessage[] = "Live long and prosper.";
 
 XdsEnd2endTest::XdsEnd2endTest(
     std::shared_ptr<ServerCredentials> balancer_credentials)
-    : event_engine_scope_(grpc_event_engine::experimental::CreateEventEngine()),
+    : scoped_event_engine_(
+          grpc_event_engine::experimental::CreateEventEngine()),
       balancer_(CreateAndStartBalancer("Default Balancer",
                                        std::move(balancer_credentials))) {
   // Initialize default client-side xDS resources.

diff --git a/test/cpp/end2end/xds/xds_end2end_test_lib.h b/test/cpp/end2end/xds/xds_end2end_test_lib.h
@@ -1046,7 +1046,7 @@ class XdsEnd2endTest : public ::testing::TestWithParam<XdsTestType>,
   // checking that all work from the current test is done, but this is not a
   // guaranteed way since there might still be threads that are not using event
   // engine but are still accessing/modifying the system state.
-  grpc_event_engine::experimental::DefaultEventEngineScope event_engine_scope_;
+  grpc_event_engine::experimental::DefaultEventEngineScope scoped_event_engine_;
 
   std::unique_ptr<BalancerServerThread> balancer_;