Clang-tidy

yashykt · Oct 11, 2024 · af8f387 · af8f387
1 parent 52a49cf
commit af8f387
Show file tree

Hide file tree

Showing 6 changed files with 534 additions and 267 deletions.
diff --git a/src/core/ext/transport/chttp2/server/chttp2_server.cc b/src/core/ext/transport/chttp2/server/chttp2_server.cc
@@ -1163,10 +1163,13 @@ void NewChttp2ServerListener::NewActiveConnection::HandshakingState::
       handshake_mgr_.get());
   handshake_mgr_->DoHandshake(
       std::move(endpoint_), channel_args, deadline_, acceptor_.get(),
-      [self = Ref()](absl::StatusOr<HandshakerArgs*> result) mutable {
+      // Using Ref().release() to since there is no guarantee between the order
+      // of the move and the use of self
+      [self = Ref().release()](absl::StatusOr<HandshakerArgs*> result) {
         self->connection_->work_serializer()->Run(
-            [self = std::move(self), result]() mutable {
+            [self, result]() mutable {
               self->OnHandshakeDoneLocked(std::move(result));
+              self->Unref();
             },
             DEBUG_LOCATION);
       });