Skip to content

Commit

Permalink
[Chttp2Server] Remove unnecessary ExecCtx Flush (grpc#37824)
Browse files Browse the repository at this point in the history
This seems to be a vestige from around 8 years ago. The code has changed a lot since then, and this makes no sense anymore.

(Making this change separately to be safe.)

Closes grpc#37824

COPYBARA_INTEGRATE_REVIEW=grpc#37824 from yashykt:RemoveUnnecessaryExecCtxStuff 97a7625
PiperOrigin-RevId: 681184980
  • Loading branch information
yashykt authored and copybara-github committed Oct 1, 2024
1 parent 9a12ec9 commit b44de39
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions src/core/ext/transport/chttp2/server/chttp2_server.cc
Original file line number Diff line number Diff line change
Expand Up @@ -783,15 +783,11 @@ Chttp2ServerListener::Chttp2ServerListener(
}

Chttp2ServerListener::~Chttp2ServerListener() {
// Flush queued work before destroying handshaker factory, since that
// may do a synchronous unref.
ExecCtx::Get()->Flush();
if (passive_listener_ != nullptr) {
passive_listener_->ListenerDestroyed();
}
if (on_destroy_done_ != nullptr) {
ExecCtx::Run(DEBUG_LOCATION, on_destroy_done_, absl::OkStatus());
ExecCtx::Get()->Flush();
}
}

Expand Down

0 comments on commit b44de39

Please sign in to comment.