Skip to content

Commit

Permalink
[MetricsTest] Reduce test logging (grpc#38582)
Browse files Browse the repository at this point in the history
This is timing out on our windows portability tests on of the tests that registers 10000 stats plugins. This log line ends up getting executed probably around ~20k times causing timeout.

Closes grpc#38582

COPYBARA_INTEGRATE_REVIEW=grpc#38582 from yashykt:MetricsTestLogging 137f850
PiperOrigin-RevId: 720305985
  • Loading branch information
yashykt authored and copybara-github committed Jan 27, 2025
1 parent 682ae95 commit c36799e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 2 additions & 0 deletions test/core/telemetry/metrics_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -706,6 +706,8 @@ TEST_F(MetricsDeathTest, RegisterTheSameMetricNameWouldCrash) {
int main(int argc, char** argv) {
grpc::testing::TestEnvironment env(&argc, argv);
::testing::InitGoogleTest(&argc, argv);
grpc_core::GlobalInstrumentsRegistryTestPeer::
ResetGlobalInstrumentsRegistry();
int ret = RUN_ALL_TESTS();
return ret;
}
2 changes: 0 additions & 2 deletions test/core/test_util/fake_stats_plugin.h
Original file line number Diff line number Diff line change
Expand Up @@ -224,8 +224,6 @@ class FakeStatsPlugin : public StatsPlugin {
descriptor) {
if (!use_disabled_by_default_metrics &&
!descriptor.enable_by_default) {
VLOG(2) << "FakeStatsPlugin[" << this
<< "]: skipping disabled metric: " << descriptor.name;
return;
}
switch (descriptor.instrument_type) {
Expand Down

0 comments on commit c36799e

Please sign in to comment.