Skip to content

Commit

Permalink
[XdsInteropClient] Remove incorrect behavior around keep-open (grpc#3…
Browse files Browse the repository at this point in the history
…8613)

Based on the [spec](https://github.com/grpc/grpc/blob/master/doc/xds-test-descriptions.md#server) and the [reference Java implementation](https://github.com/grpc/grpc-java/blob/master/interop-testing/src/main/java/io/grpc/testing/integration/XdsTestClient.java), it's the server that needs to honor the "keep-open" behavior and not the client.

(I'm not changing the server's behavior in this PR, since we are not using C++ servers and instead using Java servers for the concerned tests.)

Closes grpc#38613

COPYBARA_INTEGRATE_REVIEW=grpc#38613 from yashykt:FixXdsInteropClientBehavior 99556ba
PiperOrigin-RevId: 720999079
  • Loading branch information
yashykt committed Jan 29, 2025
1 parent b4ef7c1 commit e2c166e
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions test/cpp/interop/xds_interop_client.cc
Original file line number Diff line number Diff line change
Expand Up @@ -158,11 +158,6 @@ class TestClient {
AsyncClientCall* call = new AsyncClientCall;
for (const auto& data : config.metadata) {
call->context.AddMetadata(data.first, data.second);
// TODO(@donnadionne): move deadline to separate proto.
if (data.first == "rpc-behavior" && data.second == "keep-open") {
deadline =
std::chrono::system_clock::now() + std::chrono::seconds(INT_MAX);
}
}
SimpleRequest request;
request.set_response_size(config.response_payload_size);
Expand Down Expand Up @@ -197,11 +192,6 @@ class TestClient {
AsyncClientCall* call = new AsyncClientCall;
for (const auto& data : config.metadata) {
call->context.AddMetadata(data.first, data.second);
// TODO(@donnadionne): move deadline to separate proto.
if (data.first == "rpc-behavior" && data.second == "keep-open") {
deadline =
std::chrono::system_clock::now() + std::chrono::seconds(INT_MAX);
}
}
call->context.set_deadline(deadline);
call->result.saved_request_id = saved_request_id;
Expand Down

0 comments on commit e2c166e

Please sign in to comment.