Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove debug inspection API from localization #325

Merged
merged 4 commits into from
Jul 5, 2024
Merged

Remove debug inspection API from localization #325

merged 4 commits into from
Jul 5, 2024

Conversation

xepozz
Copy link
Member

@xepozz xepozz commented Jul 1, 2024

Q A
Is bugfix? ✔️
New feature? ❌
Breaks BC? ❌

@xepozz xepozz changed the title Fix debug inspection api Remove debug inspection API from localization Jul 1, 2024
vjik
vjik reviewed Jul 4, 2024
View reviewed changes
Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xepozz May be you whole remove localization from application template?

@xepozz
Copy link
Member Author

xepozz commented Jul 4, 2024

@vjik ¯\_(ツ)_/¯

@samdark
Copy link
Member

samdark commented Jul 4, 2024

Any idea what's wrong with tests?

@xepozz
Copy link
Member Author

xepozz commented Jul 4, 2024

I think they're all failed because of:

There was 1 error:
1) SiteControllerTest: Get index
 Test  tests/Functional/SiteControllerTest.php:testGetIndex

  [ParseError] syntax error, unexpected token "readonly", expecting "abstract" or "final" or "class"  

#1  /home/runner/work/app/app/vendor/yiisoft/yii-debug-api/src/Debug/Http/HttpApplicationWrapper.php:12

@vjik
Copy link
Member

vjik commented Jul 4, 2024

@xepozz is right. Yii Debug API declared that support PHP 8.1, but use PHP 8.2 feature "readonly".

@xepozz xepozz merged commit 4c15245 into master Jul 5, 2024
25 checks passed
@xepozz xepozz deleted the inspection-api branch July 5, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vjik vjik vjik left review comments

@samdark samdark samdark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xepozz @samdark @vjik