-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not call CommandInterface::getRawSql()
if no logger
or profiler
#781
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #781 +/- ##
=========================================
Coverage 99.64% 99.64%
- Complexity 1264 1265 +1
=========================================
Files 63 63
Lines 3062 3063 +1
=========================================
+ Hits 3051 3052 +1
Misses 11 11 ☔ View full report in Codecov by Sentry. |
PR Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If add result caching to getRawSql()
method, then we can reafactor code so:
$this->profiler?->begin($this->getRawSql(), $queryContext);
If profile is null then $this->getRawSql()
don't call.
Optimization