-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed issue #762 #913
base: master
Are you sure you want to change the base?
Fixed issue #762 #913
Conversation
evil1
commented
Dec 25, 2024
Q | A |
---|---|
Is bugfix? | ❌ |
New feature? | ✔️ |
Breaks BC? | ❌ |
Fixed issues | #762 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #913 +/- ##
=============================================
- Coverage 99.53% 59.73% -39.80%
- Complexity 1550 1554 +4
=============================================
Files 82 82
Lines 3834 3842 +8
=============================================
- Hits 3816 2295 -1521
- Misses 18 1547 +1529 ☔ View full report in Codecov by Sentry. |
@@ -574,4 +574,42 @@ public function getViewNames(string $schema = '', bool $refresh = false): array | |||
|
|||
return (array) $this->viewNames[$schema]; | |||
} | |||
|
|||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for PHPDoc since it implements interface and there phpdoc already exists.
Co-authored-by: Alexander Makarov <[email protected]>