Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #762 #913

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Fixed issue #762 #913

wants to merge 18 commits into from

Conversation

evil1
Copy link

@evil1 evil1 commented Dec 25, 2024

Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Fixed issues #762

Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 59.73%. Comparing base (4f9a12a) to head (0beb7a2).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/Schema/AbstractSchema.php 0.00% 9 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (4f9a12a) and HEAD (0beb7a2). Click for more details.

HEAD has 24 uploads less than BASE
Flag BASE (4f9a12a) HEAD (0beb7a2)
26 2
Additional details and impacted files
@@              Coverage Diff              @@
##             master     #913       +/-   ##
=============================================
- Coverage     99.53%   59.73%   -39.80%     
- Complexity     1550     1554        +4     
=============================================
  Files            82       82               
  Lines          3834     3842        +8     
=============================================
- Hits           3816     2295     -1521     
- Misses           18     1547     +1529     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/Schema/AbstractSchema.php Outdated Show resolved Hide resolved
@@ -574,4 +574,42 @@ public function getViewNames(string $schema = '', bool $refresh = false): array

return (array) $this->viewNames[$schema];
}

/**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for PHPDoc since it implements interface and there phpdoc already exists.

src/Schema/AbstractSchema.php Outdated Show resolved Hide resolved
src/Schema/AbstractSchema.php Outdated Show resolved Hide resolved
tests/Common/CommonSchemaTest.php Outdated Show resolved Hide resolved
tests/Db/Schema/SchemaTest.php Outdated Show resolved Hide resolved
src/Schema/AbstractSchema.php Outdated Show resolved Hide resolved
src/Schema/SchemaInterface.php Show resolved Hide resolved
src/Schema/SchemaInterface.php Outdated Show resolved Hide resolved
src/Schema/SchemaInterface.php Outdated Show resolved Hide resolved
src/Schema/SchemaInterface.php Outdated Show resolved Hide resolved
src/Schema/SchemaInterface.php Outdated Show resolved Hide resolved
src/Schema/SchemaInterface.php Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants