Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ColumnSchemaInterface to ColumnInterface #917

Merged
merged 3 commits into from
Jan 9, 2025
Merged

Rename ColumnSchemaInterface to ColumnInterface #917

merged 3 commits into from
Jan 9, 2025

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Jan 9, 2025 •
edited
Loading

This was referenced Jan 9, 2025
Merged
Merged
Merged
Merged
Merged
Merged
@codecov Codecov
Copy link

codecov bot commented Jan 9, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 99.09091% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.64%. Comparing base (f9976c4) to head (e3177af).

Files with missing lines Patch % Lines
src/Schema/Column/AbstractColumnFactory.php 95.45% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #917      +/-   ##
============================================
+ Coverage     99.62%   99.64%   +0.02%     
  Complexity     1498     1498              
============================================
  Files            81       81              
  Lines          3702     3702              
============================================
+ Hits           3688     3689       +1     
+ Misses           14       13       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov added the status:code review The pull request needs review. label Jan 9, 2025
@Tigrov Tigrov requested a review from a team January 9, 2025 02:50
vjik
vjik approved these changes Jan 9, 2025
View reviewed changes
src/Schema/Column/ArrayColumn.php Outdated Show resolved Hide resolved
@Tigrov @vjik
Apply @vjik suggestion [skip ci]
084f40b 
Co-authored-by: Sergei Predvoditelev <[email protected]>
@Tigrov Tigrov merged commit 98eed39 into master Jan 9, 2025
3 checks passed
@Tigrov Tigrov deleted the rename-column-schema branch January 9, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vjik vjik vjik approved these changes

Assignees
No one assigned
Labels
status:code review The pull request needs review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tigrov @vjik