-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the Label attribute #643
Conversation
dood-
commented
Dec 24, 2023
Q | A |
---|---|
Is bugfix? | ❌ |
New feature? | ✔️ |
Breaks BC? | ❌ |
Fixed issues | #633 |
PR Summary
All these changes seek to provide greater flexibility and configurability in error messages with the help of custom property labels. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #643 +/- ##
============================================
+ Coverage 94.45% 94.49% +0.04%
- Complexity 776 781 +5
============================================
Files 91 91
Lines 2361 2379 +18
============================================
+ Hits 2230 2248 +18
Misses 131 131 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need test when validated object implements LabelsProviderInterface
with and without Label
attributes usage.
Co-authored-by: Sergei Predvoditelev <[email protected]>
👍 overall. |
Co-authored-by: Alexey Rogachev <[email protected]>
Co-authored-by: Alexey Rogachev <[email protected]>
Co-authored-by: Alexey Rogachev <[email protected]>
Co-authored-by: Alexey Rogachev <[email protected]>
👍 |