add DateRule (#602) #646
Merged
add DateRule (#602) #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pamparam83
commented
Jan 11, 2024
pamparam83
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ✔️ |
| Breaks BC? | ❌ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #646 +/- ##
============================================
+ Coverage 94.49% 94.59% +0.10%
- Complexity 780 797 +17
============================================
Files 91 93 +2
Lines 2380 2425 +45
============================================
+ Hits 2249 2294 +45
Misses 131 131 ☔ View full report in Codecov by Sentry. |
samdark
reviewed
Jan 18, 2024
vjik
requested changes
Jan 20, 2024
|
@vjik I deleted the Date left the DateTime |
Tigrov
reviewed
Jan 22, 2024
Tigrov
reviewed
Jan 24, 2024
Tigrov
reviewed
Jan 25, 2024
There was a problem hiding this comment.
And need to apply suggestions by StyleCI
https://github.styleci.io/analyses/16YPnP?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
Co-authored-by: Sergei Tigrov <[email protected]>
|
StyleCI doesn't matter much. It will automatically fix style anyway. |
samdark
approved these changes
Jan 26, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.