Merge 1.4 branch to master #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vjik
commented
May 22, 2024
vjik
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
…sing()` to `Result` object (#665)
Co-authored-by: Alexey Rogachev <[email protected]> Co-authored-by: Alexander Makarov <[email protected]>
Co-authored-by: Alexander Makarov <[email protected]>
* Add aspect ratio support to `Image` rule * Apply fixes from StyleCI * Code coverage, mutants * Add detailed test cases' descriptions in data providers * Change placeholders * Work with options * Work with options 2 * More configuration checks * Fix logic, add PHPDoc * Use value object for aspect ratio * Actualize fix for mutant for absolute margin * Fix error messages * Fix new mutants * Update src/Rule/Image/ImageAspectRatio.php Co-authored-by: Sergei Predvoditelev <[email protected]> * Do not use dedicated container in tests, fix last mutant --------- Co-authored-by: StyleCI Bot <[email protected]> Co-authored-by: Sergei Predvoditelev <[email protected]>
…686) * Add `Result::add()` method for merging other results to the base one * Apply fixes from StyleCI * Update PR template [skip ci] * Update src/Result.php Co-authored-by: Alexander Makarov <[email protected]> --------- Co-authored-by: StyleCI Bot <[email protected]> Co-authored-by: Alexander Makarov <[email protected]>
* Add type rules and handlers * Apply fixes from StyleCI * Mention in the docs + basic tests * Apply fixes from StyleCI * Fix copy paste [skip ci] * Test error message * Update changelog [skip ci] * Update PHPDoc [skip ci] * More tests and descriptions * Apply fixes from StyleCI * Include type in error message * Add Any rule * Apply fixes from StyleCI * Update changelog [skip ci] * Note [skip ci] * Add translations [skip ci] * Fix tests * Test attributes * Extract PHP >= 8.1 specific tests * Apply fixes from StyleCI * Extract PHP >= 8.1 specific tests 2 * Fix mutant * Update CHANGELOG.md Co-authored-by: Sergei Predvoditelev <[email protected]> * Rename Any to AnyRule (review) --------- Co-authored-by: StyleCI Bot <[email protected]> Co-authored-by: Sergei Predvoditelev <[email protected]>
* Add methods for getting first error messages to `Result` * Bump coverage * Update src/Result.php Co-authored-by: Sergei Predvoditelev <[email protected]> * Update src/Result.php Co-authored-by: Sergei Predvoditelev <[email protected]> * Apply fixes from StyleCI * Remove newline [skip ci] * Add changelog entry [skip ci] --------- Co-authored-by: Sergei Predvoditelev <[email protected]> Co-authored-by: StyleCI Bot <[email protected]>
* Add Unique rule * Apply fixes from StyleCI * More tests, messages [WIP] * Apply fixes from StyleCI * Test traslated attributes * Test using as attribute * Ready for review * Apply fixes from StyleCI * Update src/Rule/UniqueHandler.php Co-authored-by: Dmitriy Derepko <[email protected]> * Apply fixes from StyleCI * Slightly different approach * Apply fixes from StyleCI * New test case to check strict equality * Different approach * Minor adjustments * Remove comma, rename * Update changelog [skip ci] --------- Co-authored-by: StyleCI Bot <[email protected]> Co-authored-by: Dmitriy Derepko <[email protected]> Co-authored-by: Sergei Predvoditelev <[email protected]>
Co-authored-by: Sergei Predvoditelev <[email protected]>
# Conflicts: # composer-require-checker.json # composer.json # docs/guide/en/result.md # messages/ru/yii-validator.php # src/Result.php # src/Rule/BooleanValue.php # src/Rule/Date/BaseDate.php # src/Rule/Date/BaseDateHandler.php # src/Rule/Date/Date.php # src/Rule/Date/DateHandler.php # src/Rule/Date/DateTime.php # src/Rule/Date/DateTimeHandler.php # src/Rule/Date/Time.php # src/Rule/Date/TimeHandler.php # src/Rule/Image/Image.php # src/Rule/Image/ImageHandler.php # src/Rule/NestedHandler.php # tests/Rule/Date/DateTest.php # tests/Rule/Date/DateTimeTest.php # tests/Rule/Date/TimeTest.php # tests/Rule/Image/ImageTest.php # tests/ValidatorTest.php
vjik
force-pushed
the
merge-1.4
branch
6 times, most recently
from
9096bbb to
81863d7
Compare
samdark
approved these changes
May 22, 2024
arogachev
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.