Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a check result entry to nested forms #748

Merged
merged 8 commits into from
Oct 2, 2024
Merged

Conversation

DAGpro
Copy link
Contributor

@DAGpro DAGpro commented Sep 21, 2024

Q A
Is bugfix?
New feature? ✔️
Breaks BC?

Copy link

codecov bot commented Sep 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.90%. Comparing base (fe63447) to head (e571106).
Report is 60 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #748      +/-   ##
============================================
- Coverage     94.40%   93.90%   -0.50%     
- Complexity      953     1019      +66     
============================================
  Files           108      120      +12     
  Lines          3018     3215     +197     
============================================
+ Hits           2849     3019     +170     
- Misses          169      196      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@arogachev arogachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are needed. What's the purpose of these changes exactly?

@samdark
Copy link
Member

samdark commented Sep 30, 2024

@DAGpro so it calls nested object's hooks, right?

@DAGpro
Copy link
Contributor Author

DAGpro commented Sep 30, 2024

@samdark right

Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Add test with check error path in nested object.
  2. Add line to changelog

@samdark samdark requested a review from vjik October 1, 2024 10:25
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
samdark and others added 2 commits October 1, 2024 19:04
Co-authored-by: Alexey Rogachev <[email protected]>
Co-authored-by: Alexey Rogachev <[email protected]>
CHANGELOG.md Outdated Show resolved Hide resolved
@vjik vjik merged commit 22d6572 into yiisoft:master Oct 2, 2024
24 of 26 checks passed
@vjik
Copy link
Member

vjik commented Oct 2, 2024

@DAGpro thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants