-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a check result entry to nested forms #748
Conversation
DAGpro
commented
Sep 21, 2024
Q | A |
---|---|
Is bugfix? | ❌ |
New feature? | ✔️ |
Breaks BC? | ❌ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #748 +/- ##
============================================
- Coverage 94.40% 93.90% -0.50%
- Complexity 953 1019 +66
============================================
Files 108 120 +12
Lines 3018 3215 +197
============================================
+ Hits 2849 3019 +170
- Misses 169 196 +27 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests are needed. What's the purpose of these changes exactly?
@DAGpro so it calls nested object's hooks, right? |
@samdark right |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Add test with check error path in nested object.
- Add line to changelog
Co-authored-by: Alexey Rogachev <[email protected]>
Co-authored-by: Alexey Rogachev <[email protected]>
@DAGpro thanks! |