-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include startup folder in env of PYTHONPATH #34
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made few AYON tools test and all working without any glitch.
Tried to Open/Save workfile and publish and load stuff in...all good!
I believe this PR is not needed. Because what was set in applications addon is invalid for more than half year. It did work before this PR, right? |
Indeed |
For more context to @iLLiCiTiT 's comment see his comment here. Which indeed leaves the question, is this even still needed? OR is the forced startup script once implemented just because the original way we were setting up the env vars was wrong to begin with? Like, could we avoid the forced startup script instead in favor of just setting the env var? |
but the force_startup_script.py is to execute the maxscript(startup.ms) to register the environment for the ayon plugins in 3dsmax....so it can't be removed. |
We could try to remove the pre-launch hook, and setup the My guess is that it did not work, or there were issues connected to |
My point was merely that: what if that script just exists because we were never able to pass the |
If I remember correctly that was because of the compatibility with old versions of max - they've introduced |
Changelog Description
Add startup folder in env of PYTHONPATH
Resolve #33
Additional review information
Build and Install 3dsmax Addon with this branch
Maybe some of the pre-launch hook can be removed after the implementation
Testing notes: