Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loader: Add submenu to group loaders in load context menu: #1146

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Feb 12, 2025

Changelog Description

Quick and dirty prototype to test whether grouping of loader actions is better UX or not

An env var AYON_LOADER_GROUP_MODE can be used to switch between never, multiples, always. The default is now "always". If an invalid value is set for the env var not from the aforementioned list it will silently use always

image

Additional info

This is merely a draft prototype so one can test whether it actually improves the UX.

There are some issues:

  • Submenu actions don't seem to get highlighting on mouse over
  • The context menu on the individual representations bottom right in the loader UI are also always grouped, even though there should never appear 'duplicates' in that list.
  • The "label" for the menu items is currently very hackily 'patched' from the action item by splitting of the last " (" which definitely isn't what we should do.

This may completely be superseded by way more thorough API overhaul: #1058

This is not production ready ☝️ ; it's merely intended for cosmetically testing the change

Intends to fix #1132

Testing notes:

  1. Play around and feedback on it cosmetically.

…is better UX or not

An env var `AYON_LOADER_GROUP_MODE` can be used to switch between `never`, `multiples`, `always`.
The default is now "always". If an invalid value is set for the env var not from the aforementioned list it will silently use `always`
@BigRoy BigRoy added community Issues and PRs coming from the community members type: enhancement Improvement of existing functionality or minor addition labels Feb 12, 2025
@BigRoy BigRoy self-assigned this Feb 12, 2025
@ynbot ynbot added the size/XS label Feb 12, 2025
@alainxi
Copy link

alainxi commented Feb 13, 2025

Works for me, until I try to click on the option icons (when get_options is implemented).
The icon appears in the menu, but it has no effect (the loader behaves as if I clicked on the menu, not on the icon), the option popup does not appear.

options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues and PRs coming from the community members size/XS type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load menu : add sub-menus to group loaders
3 participants