-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix logging correct default ayon_server_url
in the logged message
#127
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would simplify that error message as it still is bit confusing.
I didn't know how to reproduce it, so I just removed API key value in Deadline plugin configuration. Still received
I would remove this part of message is not the Deadline AYON" f" Plug-in default server URL '{ayon_server_url}' but
.
Message would be then (I slightly touched it up):
AYON Server URL submitted with job "
f"'{job_ayon_server_url}' has no API key defined "
"in `Additional AYON Servers` in AYON Deadline plugin "
"configuration in Deadline repository. "
" Falling back to `Ayon API key` set in `Ayon Credentials` section of "
"AYON plugin configuration.
I like the combination of |
Ayon name stays as plugin name to match other plugins
I allowed myself to update message and upper case situation :). |
client/ayon_deadline/repository/custom/plugins/GlobalJobPreLoad.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Jakub Trllo <[email protected]>
client/ayon_deadline/repository/custom/plugins/GlobalJobPreLoad.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Jakub Trllo <[email protected]>
client/ayon_deadline/repository/custom/plugins/GlobalJobPreLoad.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Jakub Trllo <[email protected]>
Changelog Description
Do not override
ayon_server_url
variable before logging it.If using a custom job url the logs should now not report the job url twice, but actually would report the 'default ayon url' to compare with. That fixes the log, and greatly clarifies the actual message too.
Additional review information
Requires updating the
GlobalJobPreLoad.py
on your Deadline repo.#42 implemented the feature originally.
Testing notes: