Added possibility to control state of Publish job in Settings and Publisher UI #131
+32
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should be collected in CollectJobInfo to track state of publish job.
kalisp
added
type: bug
kalisp
requested review from
BigRoy,
64qam,
iLLiCiTiT,
LiborBatek and
MilaKudr
iLLiCiTiT
reviewed
Feb 14, 2025
server/settings/publish_plugins.py
Outdated
| @@ -40,6 +40,7 @@ def extract_jobinfo_overrides_enum(): | |||
| {"value": "secondary_pool", "label": "Secondary pool"}, | |||
| {"value": "machine_list", "label": "Machine List"}, | |||
| {"value": "machine_list_deny", "label": "Machine List is a Deny"}, | |||
| {"value": "publish_job_suspended", "label": "Publish Job Suspended"}, | |||
There was a problem hiding this comment.
I think that "action" name is easier to understand.
Suggested change
| {"value": "publish_job_suspended", "label": "Publish Job Suspended"}, | |
| {"value": "suspend_publish_job", "label": "Suspend Publish Job"}, |
There was a problem hiding this comment.
I actually think an enum is better: seeing it then be either Queued or Suspended then it's immediately clear what happens if you do not suspend it.
Plus it'd potentially allow different states.. if there are any that make sense
There was a problem hiding this comment.
So publish_job_state instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Publish job could be set as
Suspendedto allow artist publish only after some necessary checks are made. This was previously possible only in Publisher UI, but even that was removed during refactoring.Now state of Publish job could be controlled by
Collect Job Infoconfiguration with Profiles and could be overridden by artist in Publisher UI if necessary.Testing notes:
ayon+settings://deadline/publish/CollectJobInfo/profiles/1/publish_job_suspended