Allow job environment variable to be specified via context or instance

[BigRoy]

Changelog Description

Allow job environment variable to be specified via context or instance. This allows specific hosts, or other integrations to alter the behavior of what needs to be submitted along. And also de-duplicates a lot of list of environment variables across the different submitters.

Additional info

Testing notes:

1. Deadline submissions should still work

[BigRoy]

For whatever reason the Celaction submitter has no env vars being published along - none here? @antirotor

[antirotor]

For whatever reason the Celaction submitter has no env vars being published along - none here? @antirotor

Not sure why at all, this is playground of @jakubjezek001

[kalisp]

Do we want to pass PATH env var?
Tested this PR in AE and PATH is new addition

[BigRoy]

Do we want to pass PATH env var? Tested this PR in AE and PATH is new addition

Preferably not - that's coming from the Nuke submission originally here.

I can for now move that to be Nuke-specific but preferably we can remove that completely. @antirotor @jakubjezek001 @moonyuet do you know?

For now made it backwards compatible here: 626930a by still submitting it along but only for Nuke submissions.

[moonyuet]

I can for now move that to be Nuke-specific but preferably we can remove that completely. @antirotor @jakubjezek001 @moonyuet do you know?

For now made it backwards compatible here: 626930a by still submitting it along but only for Nuke submissions.

I agree with @kalisp as it does not affect the render submission or rendering when I manually removed the environment variable and requeue the job for 3dsmax and maya

[BigRoy]

I agree with @kalisp as it does not affect the render submission or rendering when I manually removed the environment variable and requeue the job for 3dsmax and maya

Yes - thanks, it should be fixed with 626930a - can you confirm?

Preferably I'd also remove it for Nuke - but I have no clue why it was there before. We can easily remove that in a separate PR to make it a 'clear' change in the changelog. @jakubjezek001 any idea?

For whatever reason the Celaction submitter has no env vars being published along - none here?

Also @jakubjezek001 any ideas about this? I suppose it should get the env vars? If so, I can add it to the submitter if anyone is able to test it.

[moonyuet]

Tested successfully with Maya and Max.

[jakubjezek001]

Tested with CollectDeadlineNukeJobEnvVars and without, all works perfect! Lets remove the CollectDeadlineNukeJobEnvVars and keep this workflow unified with others.

[kalisp]

Tested AE, Nuke, Maya, seems fine.

[BigRoy]

For whatever reason the Celaction submitter has no env vars being published along - none here? @antirotor

Thanks everyone - only remaining piece is this question. What to do with the Celaction submitter. I suppose I should best just enforce that also passing along the env vars, right? (even if it didn't before?)

Is anyone able to test Celaction submissions?

[iLLiCiTiT]

Isn't this against proposal in ynput/ayon-core#876 ?

Just asking...

[BigRoy]

Isn't this against proposal in ynput/ayon-core#876 ?

I'd say it's actually a first step to that issue. Why do you feel it's "against" it?

[iLLiCiTiT]

I'd say it's actually a first step to that issue. Why do you feel it's "against" it?

Because we will need to change all addons to match this structure, if we add more explicit keys for publish and render jobs in future, we will have to define new keys and keep backwards compatibility, and again update all addons. Maybe not directly against, just annoying handling of backwards/forwards compatibility across all addons.