Use PublishError along publishing

client/ayon_houdini/api/lib.py

@@ -106,7 +106,7 @@ def get_output_parameter(node):
     elif node_type == "vray_renderer":
         return node.parm("SettingsOutput_img_file_path")
 
-    raise TypeError("Node type '%s' not supported" % node_type)
+    raise TypeError(f"Node type '{node_type}' is not supported")
 
 
 def get_lops_rop_context_options(
@@ -140,7 +140,8 @@ def get_lops_rop_context_options(
                 end: float = ropnode.evalParm("f2")
                 inc: float = ropnode.evalParm("f3")
             else:
-                raise ValueError("Unsupported trange value: %s" % trange)
+                raise ValueError(f"Unsupported trange value: {trange}"
+                                 f" for rop node: {ropnode.path()}")
             rop_context_options["ropcook"] = 1.0
             rop_context_options["ropstart"] = start
             rop_context_options["ropend"] = end
@@ -160,7 +161,8 @@ def get_lops_rop_context_options(
         elif option_type == "float":
             value: float = ropnode.evalParm(f"optionfloatvalue{i}")
         else:
-            raise ValueError(f"Unsupported option type: {option_type}")
+            raise ValueError(f"Unsupported option type: {option_type}"
+                             f" on rop node: '{ropnode.path()}'")
         rop_context_options[name] = value
 
     return rop_context_options

client/ayon_houdini/api/plugin.py

@@ -16,13 +16,27 @@
     AYON_INSTANCE_ID,
     AVALON_INSTANCE_ID,
     load,
-    publish
+    publish,
+    PublishError
 )
 from ayon_core.lib import BoolDef
 
-from .lib import imprint, read, lsattr, add_self_publish_button, render_rop
-from .usd import get_ayon_entity_uri_from_representation_context
+from .lib import (
+    imprint,
+    read,
+    lsattr,
+    add_self_publish_button,
+    render_rop,
+    evalParmNoFrame,
+    get_output_parameter
+)
 
+from .usd import get_ayon_entity_uri_from_representation_context
+from .colorspace import (
+    get_color_management_preferences,
+    get_scene_linear_colorspace,
+    ARenderProduct
+)
 
 SETTINGS_CATEGORY = "houdini"
 
@@ -334,6 +348,34 @@ class HoudiniInstancePlugin(pyblish.api.InstancePlugin):
     hosts = ["houdini"]
     settings_category = SETTINGS_CATEGORY
 
+    def eval_parm_no_frame(self, rop, parm, **kwargs):
+        try:
+            return evalParmNoFrame(rop, parm, **kwargs)
+        except Exception as exc:
+            raise PublishError(
+                f"Failed evaluating parameter '{parm}' on Rop node: {rop.path()}",
+                detail=str(exc)
+            )
+
+    def get_output_parameter(self, node):
+        try:
+            return get_output_parameter(node)
+        except Exception as exc:
+            raise PublishError(
+                f"Node type '{node}' is not supported",
+                detail=str(exc)
+            )
+
+    def get_scene_linear_colorspace(self):
+        try:
+            return get_scene_linear_colorspace()
+        except Exception as exc:
+            raise PublishError(
+                "Failed to get scene linear colorspace.",
+                detail=str(exc)
+            )
+
+
 
 class HoudiniContextPlugin(pyblish.api.ContextPlugin):
     """Base class for Houdini context publish plugins."""

client/ayon_houdini/plugins/publish/collect_arnold_rop.py

@@ -5,7 +5,6 @@
 import pyblish.api
 
 from ayon_houdini.api import plugin
-from ayon_houdini.api.lib import evalParmNoFrame
 
 
 class CollectArnoldROPRenderProducts(plugin.HoudiniInstancePlugin):
@@ -28,13 +27,13 @@ def process(self, instance):
 
         rop = hou.node(instance.data.get("instance_node"))
 
-        default_prefix = evalParmNoFrame(rop, "ar_picture")
+        default_prefix = self.eval_parm_no_frame(rop, "ar_picture")
         render_products = []
 
         export_prefix = None
         export_products = []
         if instance.data["splitRender"]:
-            export_prefix = evalParmNoFrame(
+            export_prefix = self.eval_parm_no_frame(
                 rop, "ar_ass_file", pad_character="0"
             )
             beauty_export_product = self.get_render_product_name(
@@ -74,7 +73,7 @@ def process(self, instance):
             if rop.evalParm("ar_aov_exr_enable_layer_name{}".format(index)):
                 label = rop.evalParm("ar_aov_exr_layer_name{}".format(index))
             else:
-                label = evalParmNoFrame(rop, "ar_aov_label{}".format(index))
+                label = self.eval_parm_no_frame(rop, "ar_aov_label{}".format(index))
 
             # NOTE:
             #  we don't collect the actual AOV path but rather assume 

client/ayon_houdini/plugins/publish/collect_cache_farm.py

@@ -1,10 +1,7 @@
 import os
 import hou
 import pyblish.api
-from ayon_houdini.api import (
-    lib,
-    plugin
-)
+from ayon_houdini.api import plugin
 
 
 class CollectFarmCacheFamily(plugin.HoudiniInstancePlugin):
@@ -44,7 +41,7 @@ def process(self, instance):
         #               and CollectKarmaROPRenderProducts
         # Collect expected files
         ropnode = hou.node(instance.data["instance_node"])
-        output_parm = lib.get_output_parameter(ropnode)
+        output_parm = self.get_output_parameter(ropnode)
         expected_filepath = output_parm.eval()
 
         files = instance.data.setdefault("files", list())

client/ayon_houdini/plugins/publish/collect_frames.py

@@ -4,7 +4,7 @@
 import hou  # noqa
 import clique
 import pyblish.api
-from ayon_houdini.api import lib, plugin
+from ayon_houdini.api import plugin
 
 
 class CollectFrames(plugin.HoudiniInstancePlugin):
@@ -27,7 +27,7 @@ def process(self, instance):
 
         # Evaluate the file name at the first frame.
         ropnode = hou.node(instance.data["instance_node"])
-        output_parm = lib.get_output_parameter(ropnode)
+        output_parm = self.get_output_parameter(ropnode)
         output = output_parm.evalAtFrame(start_frame)
         file_name = os.path.basename(output)
 

client/ayon_houdini/plugins/publish/collect_karma_rop.py

@@ -4,7 +4,6 @@
 import hou
 import pyblish.api
 
-from ayon_houdini.api.lib import evalParmNoFrame
 from ayon_houdini.api import plugin
 
 
@@ -28,7 +27,7 @@ def process(self, instance):
 
         rop = hou.node(instance.data.get("instance_node"))
 
-        default_prefix = evalParmNoFrame(rop, "picture")
+        default_prefix = self.eval_parm_no_frame(rop, "picture")
         render_products = []
 
         # Default beauty AOV

client/ayon_houdini/plugins/publish/collect_local_render_instances.py

@@ -12,7 +12,6 @@
     ColormanagedPyblishPluginMixin
 )
 from ayon_houdini.api import plugin
-from ayon_houdini.api.colorspace import get_scene_linear_colorspace
 
 
 class CollectLocalRenderInstances(plugin.HoudiniInstancePlugin,
@@ -87,7 +86,7 @@ def process(self, instance):
         #   would need to be detected in a renderer-specific way and the
         #   majority of production scenarios these would not be overridden.
         # TODO: Support renderer-specific explicit colorspace overrides
-        colorspace = get_scene_linear_colorspace()
+        colorspace = self.get_scene_linear_colorspace()
 
         for aov_name, aov_filepaths in expected_files.items():
             dynamic_data = {}

client/ayon_houdini/plugins/publish/collect_mantra_rop.py

@@ -4,7 +4,6 @@
 import hou
 import pyblish.api
 
-from ayon_houdini.api.lib import evalParmNoFrame
 from ayon_houdini.api import plugin
 
 
@@ -28,13 +27,13 @@ def process(self, instance):
 
         rop = hou.node(instance.data.get("instance_node"))
 
-        default_prefix = evalParmNoFrame(rop, "vm_picture")
+        default_prefix = self.eval_parm_no_frame(rop, "vm_picture")
         render_products = []
 
         export_prefix = None
         export_products = []
         if instance.data["splitRender"]:
-            export_prefix = evalParmNoFrame(
+            export_prefix = self.eval_parm_no_frame(
                 rop, "soho_diskfile", pad_character="0"
             )
             beauty_export_product = self.get_render_product_name(
@@ -74,7 +73,7 @@ def process(self, instance):
                     aov_enabled = rop.evalParm(aov_boolean)
                     has_aov_path = rop.evalParm(aov_name)
                     if has_aov_path and aov_enabled == 1:
-                        aov_prefix = evalParmNoFrame(rop, aov_name)
+                        aov_prefix = self.eval_parm_no_frame(rop, aov_name)
                         aov_product = self.get_render_product_name(
                             prefix=aov_prefix, suffix=None
                         )

client/ayon_houdini/plugins/publish/collect_output_node.py

@@ -1,5 +1,5 @@
 import pyblish.api
-from ayon_core.pipeline.publish import KnownPublishError
+from ayon_core.pipeline.publish import PublishError
 from ayon_houdini.api import plugin
 
 
@@ -67,8 +67,8 @@ def process(self, instance):
             out_node = node.parm("startnode").evalAsNode()
 
         else:
-            raise KnownPublishError(
-                "ROP node type '{}' is not supported.".format(node_type)
+            raise PublishError(
+                f"ROP node type '{node_type}' is not supported."
             )
 
         if not out_node:

client/ayon_houdini/plugins/publish/collect_redshift_rop.py

@@ -4,7 +4,6 @@
 import hou
 import pyblish.api
 
-from ayon_houdini.api.lib import evalParmNoFrame
 from ayon_houdini.api import plugin
 
 
@@ -27,12 +26,12 @@ class CollectRedshiftROPRenderProducts(plugin.HoudiniInstancePlugin):
     def process(self, instance):
         rop = hou.node(instance.data.get("instance_node"))
 
-        default_prefix = evalParmNoFrame(rop, "RS_outputFileNamePrefix")
+        default_prefix = self.eval_parm_no_frame(rop, "RS_outputFileNamePrefix")
         beauty_suffix = rop.evalParm("RS_outputBeautyAOVSuffix")
 
         export_products = []
         if instance.data["splitRender"]:
-            export_prefix = evalParmNoFrame(
+            export_prefix = self.eval_parm_no_frame(
                 rop, "RS_archive_file", pad_character="0"
             )
             beauty_export_product = self.get_render_product_name(
@@ -80,7 +79,7 @@ def process(self, instance):
                 continue
 
             aov_suffix = rop.evalParm(f"RS_aovSuffix_{i}")
-            aov_prefix = evalParmNoFrame(rop, f"RS_aovCustomPrefix_{i}")
+            aov_prefix = self.eval_parm_no_frame(rop, f"RS_aovCustomPrefix_{i}")
             if not aov_prefix:
                 aov_prefix = default_prefix
 

client/ayon_houdini/plugins/publish/collect_render_colorspace.py

@@ -1,4 +1,9 @@
-from ayon_houdini.api import plugin, colorspace
+from ayon_core.pipeline import PublishError
+from ayon_houdini.api import plugin
+from ayon_houdini.api.colorspace import (
+    ARenderProduct,
+    get_color_management_preferences
+)
 
 import pyblish.api
 
@@ -32,14 +37,27 @@ def process(self, instance):
                            "Skipping collecting of render colorspace.")
             return
         aov_name = list(expected_files[0].keys())
-        render_products_data = colorspace.ARenderProduct(aov_name)
+        try:
+            render_products_data = ARenderProduct(aov_name)
+        except Exception as exc:
+            raise PublishError(
+                "Failed to get render products with colorspace.",
+                detail=str(exc)
+            )
         instance.data["renderProducts"] = render_products_data
 
         # Required data for `create_instances_for_aov`
-        colorspace_data = colorspace.get_color_management_preferences()
+        try:
+            colorspace_data = get_color_management_preferences()
+        except Exception as exc:
+            raise PublishError(
+                "Failed to get color management preferences.",
+                detail=str(exc)
+            )
+
         instance.data["colorspaceConfig"] = colorspace_data["config"]
         instance.data["colorspaceDisplay"] = colorspace_data["display"]
         instance.data["colorspaceView"] = colorspace_data["view"]
 
         # Used in `create_skeleton_instance()`
-        instance.data["colorspace"] = colorspace.get_scene_linear_colorspace()
+        instance.data["colorspace"] = self.get_scene_linear_colorspace()

client/ayon_houdini/plugins/publish/collect_render_products.py

@@ -6,6 +6,7 @@
 
 import pyblish.api
 
+from ayon_core.pipeline.publish import PublishError
 from ayon_houdini.api import plugin
 from ayon_houdini.api.usd import (
     get_usd_render_rop_rendersettings
@@ -107,10 +108,10 @@ def replace(match):
                 filename = os.path.join(dirname, filename_base)
                 filename = filename.replace("\\", "/")
 
-            assert "#" in filename, (
-                "Couldn't resolve render product name "
-                "with frame number: %s" % name
-            )
+            if "#" not in filename:
+                raise PublishError(
+                    f"Couldn't resolve render product name with frame number: {name}"
+                )
 
             filenames.append(filename)
 

client/ayon_houdini/plugins/publish/collect_usd_layers.py

@@ -5,6 +5,7 @@
 import pyblish.api
 
 from ayon_core.pipeline.create import get_product_name
+from ayon_core.pipeline.publish import PublishError
 from ayon_houdini.api import plugin
 import ayon_houdini.api.usd as usdlib
 
@@ -71,7 +72,15 @@ def process(self, instance):
         rop_node = hou.node(instance.data["instance_node"])
 
         save_layers = []
-        for layer in usdlib.get_configured_save_layers(rop_node):
+        try:
+            layers = usdlib.get_configured_save_layers(rop_node)
+        except Exception as exc:
+            raise PublishError(
+                f"Failed to get USD layers on rop node '{rop_node}'",
+                detail=str(exc)
+            )
+
+        for layer in layers:
 
             info = layer.rootPrims.get("HoudiniLayerInfo")
             save_path = info.customData.get("HoudiniSavePath")
@@ -147,10 +156,16 @@ def process(self, instance):
 
             # Inherit "use handles" from the source instance
             # TODO: Do we want to maybe copy full `publish_attributes` instead?
-            copy_instance_data(
-                instance, layer_inst,
-                attr="publish_attributes.CollectRopFrameRange.use_handles"
-            )
+            try:
+                copy_instance_data(
+                    instance, layer_inst,
+                    attr="publish_attributes.CollectRopFrameRange.use_handles"
+                )
+            except Exception as exc:
+                raise PublishError(
+                    "Failed to copy instance data.",
+                    detail=str(exc)
+                )
 
             # Allow this subset to be grouped into a USD Layer on creation
             layer_inst.data["productGroup"] = (