[WIP] Clean up StarboardBridge #4632
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haozheng-cobalt
force-pushed
the
jni-1227
branch
3 times, most recently
from
270b2a3 to
cefa499
Compare
haozheng-cobalt
force-pushed
the
jni-1227
branch
from
cefa499 to
5706411
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove @UsedByNative annotations for beforeStartOrResume and beforeSuspend, for they are no longer needed in ApplicationAndroid. Reference b/377042903.
Remove getLocalInterfaceAddressAndNetmask and isCurrentNetworkWireless, for it's not used in Chrobalt.
Remove @UsedByNative annotations for getDisplaySize, for it's never used in native code.
Change UA related fields getIsAmatiDevice, getBuildFingerprint, getPlayServicesVersion to @CalledByNative, we are currently not using them in UserAgentPlatformInfo::ToString(), but might need them for cobalt/browser/client_hint_headers.cc in the future.
Migrate the rest of JNI calls in starboard/android/shared/android_main.cc to Chromium standard JNI,
When testing locally:
startDeepLink is set with empty string.
GetArgs retrieves url.
01-02 22:06:07.303 13993 13993 I starboard: [dev.cobalt.coat/13993:0103/060607.300538(UTC):INFO:android_main.cc(76)] Test GetArgs: android_main--url=https://www.youtube.com/tv