Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(options) Added wsEngine to the options list (fixes #62, #57, #58) #63

Merged
merged 1 commit into from
Nov 16, 2018

Conversation

somq
Copy link
Contributor

@somq somq commented Oct 7, 2018

fixes #62, #57, #58
feat(options) Added wsEngine to the options list and updated doc to list all the available options

@pbassut
Copy link

pbassut commented Oct 22, 2018

Can we get this in @zalmoxisus ?

@RobPethick
Copy link

+1 putting this in myself as a custom option seems to be the only way for me to get my web sockets working. the npm library uws is marked as deprecated, if we can have the option to use ws instead that is a big win

@zalmoxisus zalmoxisus merged commit 35b8bb2 into zalmoxisus:master Nov 16, 2018
@zalmoxisus
Copy link
Owner

This is available in 0.2.7. Thanks for working on this and sorry for the delay!

After #65 uws shouldn't be required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants