Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle null requestPort #547

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Handle null requestPort #547

merged 1 commit into from
Oct 22, 2024

Conversation

ludovicm67
Copy link
Member

Fix requestPort value, to handle null cases.

Copy link

changeset-bot bot commented Oct 22, 2024

🦋 Changeset detected

Latest commit: 5476c37

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
trifid-plugin-yasgui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.54%. Comparing base (79a6d7f) to head (5476c37).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #547   +/-   ##
=======================================
  Coverage   70.54%   70.54%           
=======================================
  Files          54       54           
  Lines        3439     3439           
=======================================
  Hits         2426     2426           
  Misses       1013     1013           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ludovicm67 ludovicm67 merged commit f21accf into main Oct 22, 2024
9 checks passed
@ludovicm67 ludovicm67 deleted the yasgui-request-port branch October 22, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant