Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Entity-renderer] Add more tests and fix a bug when enableSchemaUrlRedirect=true #604

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

ludovicm67
Copy link
Member

This adds more tests to cover the enableSchemaUrlRedirect feature.

It also fixes an issue that was leading to wrong results in case the schema:URL value is not having a xsd:anyURL datatype.

@ludovicm67 ludovicm67 self-assigned this Dec 17, 2024
Copy link

changeset-bot bot commented Dec 17, 2024

🦋 Changeset detected

Latest commit: 86e4332

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@zazuko/trifid-entity-renderer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.11%. Comparing base (9b396c2) to head (86e4332).
Report is 14 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #604   +/-   ##
=======================================
  Coverage   71.10%   71.11%           
=======================================
  Files          55       55           
  Lines        3565     3566    +1     
=======================================
+ Hits         2535     2536    +1     
  Misses       1030     1030           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ludovicm67 ludovicm67 merged commit 6bb2654 into main Dec 17, 2024
9 checks passed
@ludovicm67 ludovicm67 deleted the er-fix-datatype-value-check branch December 17, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant