Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vitesse theme refined #1838

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

colinlienard
Copy link
Contributor

@colinlienard colinlienard commented Dec 28, 2024

There is already an auto-generated vitesse theme in Zed, but this one corrects color inaccuracies and fills in missing colors.

https://github.com/colinlienard/zed-vitesse-theme-refined

This comment has been minimized.

@colinlienard

This comment has been minimized.

@cla-bot cla-bot bot added the cla-signed label Dec 28, 2024

This comment has been minimized.

@colinlienard colinlienard marked this pull request as ready for review December 28, 2024 10:54
@notpeter
Copy link
Member

notpeter commented Jan 1, 2025

Have you reached out to the existing Vitesse Theme (d1y/vitesse.zed) maintainer @d1y to see if they would be willing to merge your changes / add you as a maintainer?

I'm willing to merge this separately too, but just thought I'd ask because I'd rather have one Vitesse theme than two divergent ones if possible.

@colinlienard
Copy link
Contributor Author

@notpeter I did not because I wasn't sure how to contact them, but I will create an issue on their repo to see if we can somehow merge our work

@colinlienard
Copy link
Contributor Author

Hi @notpeter, since it’s been over a week without a response from @d1y, would it make sense to go ahead and merge this PR as a separate extension?

@notpeter notpeter merged commit e26f890 into zed-industries:main Jan 14, 2025
3 checks passed
@notpeter
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants