This repository has been archived by the owner on Apr 6, 2022. It is now read-only.
check_compliance.py: Check for duplicated dependencies on Kconfig syms #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking DNM until I've fixed the stuff it flags in Zephyr. |
|
All checks are passing now. Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages. |
ulfalizer
force-pushed
the
check-dup-deps
branch
from
c8fa14b to
706680b
Compare
ulfalizer
added a commit
to ulfalizer/zephyr
that referenced
this pull request
Feb 7, 2020
Kconfig.tls-generic is already 'source'd within an 'if MBEDTLS' in modules/Kconfig.mbedtls (the 'if' covers most of the file). Flagged by zephyrproject-rtos/ci-tools#128. Signed-off-by: Ulf Magnusson <[email protected]>
carlescufi
pushed a commit
to zephyrproject-rtos/zephyr
that referenced
this pull request
Feb 7, 2020
Kconfig.tls-generic is already 'source'd within an 'if MBEDTLS' in modules/Kconfig.mbedtls (the 'if' covers most of the file). Flagged by zephyrproject-rtos/ci-tools#128. Signed-off-by: Ulf Magnusson <[email protected]>
ulfalizer
added a commit
to ulfalizer/zephyr
that referenced
this pull request
Feb 7, 2020
CUSTOM_SECTION_ALIGN is already defined within an 'if ARM_MPU', so it does not need a 'depends on ARM_MPU'. Flagged by zephyrproject-rtos/ci-tools#128. Signed-off-by: Ulf Magnusson <[email protected]>
ulfalizer
added a commit
to ulfalizer/zephyr
that referenced
this pull request
Feb 7, 2020
Flagged by zephyrproject-rtos/ci-tools#128. Signed-off-by: Ulf Magnusson <[email protected]>
Check for e.g. 'if FOO' within 'if FOO', or 'depends on FOO' within 'if FOO'. Such duplicated dependencies make it easier to mess up changes to Kconfig files (because it's not obvious that the same dependency is added twice), and make the autogenerated documentation uglier. Some of them might have been added due to Kconfig misunderstandings too. Signed-off-by: Ulf Magnusson <[email protected]>
ulfalizer
force-pushed
the
check-dup-deps
branch
from
706680b to
d5c6fec
Compare
MaureenHelm
pushed a commit
to zephyrproject-rtos/zephyr
that referenced
this pull request
Feb 7, 2020
Flagged by zephyrproject-rtos/ci-tools#128. Signed-off-by: Ulf Magnusson <[email protected]>
MaureenHelm
pushed a commit
to zephyrproject-rtos/zephyr
that referenced
this pull request
Feb 7, 2020
CUSTOM_SECTION_ALIGN is already defined within an 'if ARM_MPU', so it does not need a 'depends on ARM_MPU'. Flagged by zephyrproject-rtos/ci-tools#128. Signed-off-by: Ulf Magnusson <[email protected]>
ulfalizer
added a commit
to ulfalizer/zephyr
that referenced
this pull request
Feb 8, 2020
This symbol is already defined within an 'if SPI_DW'. Flagged by zephyrproject-rtos/ci-tools#128. Signed-off-by: Ulf Magnusson <[email protected]>
ulfalizer
added a commit
to ulfalizer/zephyr
that referenced
this pull request
Feb 8, 2020
Kconfig.rv32m1 is already 'source'd within an 'if ENTROPY_GENERATOR', so ENTROPY_RV32M1_TRNG does not need a 'depends on ENTROPY_GENERATOR'. Flagged by zephyrproject-rtos/ci-tools#128. Signed-off-by: Ulf Magnusson <[email protected]>
jhedberg
pushed a commit
to zephyrproject-rtos/zephyr
that referenced
this pull request
Feb 8, 2020
This symbol is already defined within an 'if SPI_DW'. Flagged by zephyrproject-rtos/ci-tools#128. Signed-off-by: Ulf Magnusson <[email protected]>
galak
pushed a commit
to zephyrproject-rtos/zephyr
that referenced
this pull request
Feb 12, 2020
Kconfig.rv32m1 is already 'source'd within an 'if ENTROPY_GENERATOR', so ENTROPY_RV32M1_TRNG does not need a 'depends on ENTROPY_GENERATOR'. Flagged by zephyrproject-rtos/ci-tools#128. Signed-off-by: Ulf Magnusson <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for e.g. 'if FOO' within 'if FOO', or 'depends on FOO' within 'if
FOO'. Such duplicated dependencies make it easier to mess up changes to
Kconfig files (because it's not obvious that the same dependency is
added twice), and make the autogenerated documentation uglier.
Some of them might have been added due to Kconfig misunderstandings too.