Skip to content

Commit

Permalink
refactor: Improve performance
Browse files Browse the repository at this point in the history
SEO improvement
- about.md: Add description label
- contact.md: Add description label
- services.md : Add description label

Accessibility improvement
- footer.html: Replace <h3> by <h2>
- team.html: Increase contrast ratio

Security improvement
- teams.html: Fix LinkedIn link

Performance improvement
- teams.html: Set width and height for img
- ...

For the whole site:

100/100 Google Lighthouse speed score
100/100 Google Lighthouse seo score
100/100 Google Lighthouse accessibility score
100/100 Google Lighthouse best practices score
  • Loading branch information
root committed Aug 6, 2021
1 parent d9528cf commit e640db6
Show file tree
Hide file tree
Showing 31 changed files with 28 additions and 10 deletions.
4 changes: 2 additions & 2 deletions _includes/footer.html
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<div class="row">
<div class="col-12">
<div class="footer-inner">
<h3 class="footer-title">{{site.title}}</h3>
<h2 class="footer-title">{{site.title}}</h2>
<ul>
{% assign footermenu = site.data.menus.footer | sort: 'weight' %}
{% for item in footermenu %}
Expand All @@ -16,4 +16,4 @@ <h3 class="footer-title">{{site.title}}</h3>
</div>
</div>
</div>
</div>
</div>
6 changes: 3 additions & 3 deletions _layouts/teams.html
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,14 @@
<div class="team team-summary team-summary-large">
{% if team.image %}
<div class="team-image">
<img alt="{{ team.title }}" class="img-fluid mb-2" src="{{ team.image | relative_url }}" />
<img width="{{ team.image_width }}" height="{{ team.image_height }}" alt="{{ team.title }}" class="img-fluid mb-2" src="{{ team.image | relative_url }}" />
</div>
{% endif %}
<div class="team-meta">
<h2 class="team-name"><a href="{{ team.url | relative_url }}">{{ team.title }}</a></h2>
<p class="team-description">{{ team.jobtitle }}</p>
{% if team.linkedinurl %}
<a target="_blank" href="{{ team.linkedinurl }}">LinkedIn</a>
<a target="_blank" href="{{ team.linkedinurl }}" rel="noreferrer">LinkedIn</a>
{% endif %}
</div>
<div class="team-content">{{ team.content | truncate: 120 }}</div>
Expand All @@ -48,7 +48,7 @@ <h2 class="team-name"><a href="{{ team.url | relative_url }}">{{ team.title }}</
<div class="team team-summary">
{% if team.image %}
<div class="team-image">
<img alt="{{ team.title }}" class="img-fluid mb-2" src="{{ team.image | relative_url }}" />
<img width="{{ team.image_width }}" height="{{ team.image_height }}" alt="{{ team.title }}" class="img-fluid mb-2" src="{{ team.image | relative_url }}" />
</div>
{% endif %}
<div class="team-meta">
Expand Down
2 changes: 1 addition & 1 deletion _sass/components/_type.scss
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
a {
color: $primary;
color: $primary-dark;
}
p {
line-height: 26px;
Expand Down
2 changes: 2 additions & 0 deletions _team/bill-mcdonald.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ title: "Bill McDonald"
date: 2018-11-19T10:47:58+10:00
draft: false
image: "images/team/nonsap-visuals-kMJp7620W6U-unsplash.jpg"
image_width: 60
image_height: 60
jobtitle: "Graphic Designer"
linkedinurl: ""
weight: 7
Expand Down
2 changes: 2 additions & 0 deletions _team/mike-vance.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ title: 'Mike Vance'
date: 2018-12-20T13:44:30+10:00
draft: false
image: 'images/team/joseph-gonzalez-399972-unsplash.jpg'
image_width: 60
image_height: 60
jobtitle: 'Art Director'
linkedinurl: ""
weight: 3
Expand Down
2 changes: 2 additions & 0 deletions _team/peter-van-eijk.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ title: "Peter Van Eijk"
date: 2018-11-19T10:47:58+10:00
draft: false
image: "images/team/peter-van-eijk-711986-unsplash.jpg"
image_width: 90
image_height: 90
jobtitle: "Director"
linkedinurl: "https://www.linkedin.com/"
promoted: true
Expand Down
2 changes: 2 additions & 0 deletions _team/robert-johnson.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ title: 'Robert Johnson'
date: 2018-12-20T13:44:23+10:00
draft: false
image: 'images/team/vince-fleming-613817-unsplash.jpg'
image_width: 60
image_height: 60
jobtitle: 'Developer'
linkedinurl: "https://www.linkedin.com/"
weight: 3
Expand Down
2 changes: 2 additions & 0 deletions _team/sage-kirk.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ title: "Sage Kirk"
date: 2018-11-19T10:47:58+10:00
draft: false
image: "images/team/sage-kirk-485982-unsplash.jpg"
image_width: 90
image_height: 90
jobtitle: "Accounting Partner"
linkedinurl: "https://www.linkedin.com/example2"
promoted: true
Expand Down
2 changes: 2 additions & 0 deletions _team/susan-shelton.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ title: 'Susan Shelton'
date: 2018-12-20T13:45:06+10:00
draft: false
image: 'images/team/cristian-newman-94319-unsplash.jpg'
image_width: 60
image_height: 60
jobtitle: 'Developer'
weight: 5
---
Expand Down
2 changes: 2 additions & 0 deletions _team/tamara-ells.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ title: 'Tamara Ells'
date: 2018-12-20T13:44:55+10:00
draft: false
image: 'images/team/michael-dam-258165-unsplash.jpg'
image_width: 60
image_height: 60
jobtitle: 'UI Designer'
weight: 4
---
Expand Down
4 changes: 2 additions & 2 deletions about.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
title: "About"
date: 2018-02-22T17:01:34+07:00
title: About
layout: page
description: About
bodyClass: page-about
---

Expand Down
3 changes: 2 additions & 1 deletion assets/css/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,13 @@
---

// Colors
$primary: #E5261F;
$primary: #e5261f;
$secondary: #f88379;
$black: #2f2f41;
$white: #ffffff;
$white-offset: #fff6f8;
$steel: #5C5A5A;
$primary-dark: #a01b16;

// Links
$link-color: $primary;
Expand Down
1 change: 1 addition & 0 deletions contact.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
---
title: Contact
layout: contact
description: Contact
---

Lorem markdownum aequalis strigis. Saetigeri iubeas, vultu huic alvum nondum de obside ut laniavit arbor palmis, cum quin. Rupes vetat videndo, armigerae crimen habet Priamum nec.
Expand Down
Binary file modified images/team/cristian-newman-94319-unsplash.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified images/team/joseph-gonzalez-399972-unsplash.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified images/team/michael-dam-258165-unsplash.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified images/team/nonsap-visuals-kMJp7620W6U-unsplash.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified images/team/peter-van-eijk-711986-unsplash.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified images/team/sage-kirk-485982-unsplash.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified images/team/sung-wang-g4DgCF90EM4-unsplash.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified images/team/vince-fleming-613817-unsplash.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 2 additions & 1 deletion services.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
---
title: Services
layout: services
description: Services
intro_image: "images/illustrations/reading.svg"
intro_image_absolute: true
intro_image_hide_on_mobile: false
intro_image_hide_on_mobile: true
---

# Services that grow with your business
Expand Down
1 change: 1 addition & 0 deletions team.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
---
title: Team
layout: teams
description: Team
permalink: "/team/"
intro_image_absolute: true
intro_image_hide_on_mobile: false
Expand Down

0 comments on commit e640db6

Please sign in to comment.