Build with Java 8 and disable Moditect plugin on it

zeroturnaround · Apr 16, 2023 · 812eb73 · 812eb73
1 parent f6850d1
commit 812eb73
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 2 deletions.
diff --git a/.github/workflows/maven.yml b/.github/workflows/maven.yml
@@ -8,7 +8,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        java: [ 6, 9, 11, 17 ]
+        java: [ 6, 8, 11, 17 ]
     name: Build with Java ${{ matrix.java }}
     steps:
       - name: Checkout
@@ -63,9 +63,16 @@ jobs:
           chmod +x mvnw
           ./mvnw -ntp -B -P java6 -DtestJdk=17 test
 
+      - name: Build on Java 8, run tests with Java 17
+        # Java 8 is also a special case, we need to activate a profile on it
+        if: ${{ matrix.java == '8'}}
+        run: |
+          chmod +x mvnw
+          ./mvnw -ntp -B -P java8 -DtestJdk=17 test
+
       - name: Build and test on Java ${{ matrix.java }}
         # More modern JDKs support specifying a target JDK release for the compiler
-        if: ${{ matrix.java != '6'}}
+        if: ${{ matrix.java != '6' && matrix.java != '8' }}
         run: |
           chmod +x mvnw
           ./mvnw -ntp -B -DmainJdk=${{ matrix.java }} verify package

diff --git a/pom.xml b/pom.xml
@@ -299,6 +299,24 @@ Export-Package:\
         </plugins>
       </build>
     </profile>
+    <profile>
+      <id>java8</id>
+      <build>
+        <plugins>
+          <plugin>
+            <groupId>org.moditect</groupId>
+            <artifactId>moditect-maven-plugin</artifactId>
+            <version>1.0.0.RC3</version>
+            <executions>
+              <execution>
+                <id>add-module-infos</id>
+                <phase>none</phase>
+              </execution>
+            </executions>
+          </plugin>
+        </plugins>
+      </build>
+    </profile>
   </profiles>
 
   <organization>