Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scipy gaussian import to avoid deprecation warnings #272

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

ysalatheZI
Copy link
Collaborator

Description:

When running the example shfqa_qubit_readout_measurement.md, I've encountered the following deprecation warning from the SciPy library for the gaussian function:

DeprecationWarning: Importing gaussian from 'scipy.signal' is deprecated and will raise an error in SciPy 1.13.0. Please use 'scipy.signal.windows.gaussian' or the convenience function 'scipy.signal.get_window' instead.
  gauss = gaussian(2 * rise_fall_len, std_dev)

Therefore, this PR updates the import statements for this library function.

Fixes issue: #

Checklist:

  • Add tests for the change to show correct behavior.
  • Add or update relevant docs, code and examples.
  • Update CHANGELOG.rst with relevant information and add the issue number.
  • Add .. versionchanged:: where necessary.

@ysalatheZI ysalatheZI requested a review from tobiasah December 6, 2023 12:44
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9394cd7) 99.61% compared to head (3c85466) 99.61%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #272   +/-   ##
=======================================
  Coverage   99.61%   99.61%           
=======================================
  Files          40       40           
  Lines        2575     2575           
=======================================
  Hits         2565     2565           
  Misses         10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tobiasah tobiasah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ Thanks for fixing this

@ysalatheZI ysalatheZI merged commit cdeaf58 into main Dec 7, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants