Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various compile errors #13

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Conversation

simeks
Copy link
Contributor

@simeks simeks commented Jan 12, 2025

I found a few more compile errors so I made some minor fixes.

For the Window methods I guess it might make more sense to just keep the alias as-is and change the names in the module itself instead (setWindowPosCallback instead of setPosCallback), but I'll leave that for you to decide.

As for breaking things:

  • I changed Monitor.getPos to work just as Window.getPos. Return c_int as provided by the GLFW API, and return an array instead of a slice.
  • focuswindow -> focusWindow, assuming this was a typo.

@hazeycode
Copy link
Member

hazeycode commented Jan 13, 2025

Thanks!

For top-level fn names I think we should prefer sticking to how they are named in glfw rather than changing them. As this offers the least surprises for users of that API. For our "scoped aliases" however, we can deviate from underlying api naming somewhat.

@simeks
Copy link
Contributor Author

simeks commented Jan 13, 2025

Thanks for the quick response! That makes sense, so now I've changed the top-level function names instead.

@hazeycode hazeycode merged commit 1c8f7de into zig-gamedev:main Jan 17, 2025
3 checks passed
@hazeycode
Copy link
Member

Thanks!

hazeycode pushed a commit that referenced this pull request Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants