change to telemetry and to pom

zinggAI · Oct 25, 2024 · 3c543f0 · 3c543f0
1 parent b796582
commit 3c543f0
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/common/core/src/main/java/zingg/common/core/executor/ZinggBase.java b/common/core/src/main/java/zingg/common/core/executor/ZinggBase.java
@@ -91,14 +91,13 @@ public void postMetrics() {
         Analytics.track(Metric.ZINGG_VERSION, "0.4.1-SNAPSHOT", collectMetrics);
         Analytics.trackEnvProp(Metric.DATABRICKS_RUNTIME_VERSION, collectMetrics);
         Analytics.trackEnvProp(Metric.DB_INSTANCE_TYPE, collectMetrics);
-        Analytics.trackEnvProp(Metric.JAVA_HOME, collectMetrics); 
-        Analytics.trackEnvProp(Metric.JAVA_VERSION, collectMetrics); 
-        Analytics.trackEnvProp(Metric.OS_ARCH, collectMetrics); 
-        Analytics.trackEnvProp(Metric.OS_NAME, collectMetrics); 
+        //Analytics.trackEnvProp(Metric.JAVA_HOME, collectMetrics); 
+        //Analytics.trackEnvProp(Metric.JAVA_VERSION, collectMetrics); 
+        //Analytics.trackEnvProp(Metric.OS_ARCH, collectMetrics); 
+        //Analytics.trackEnvProp(Metric.OS_NAME, collectMetrics); 
         //Analytics.trackEnvProp(Metric.USER_NAME, collectMetrics); 
         //Analytics.trackEnvProp(Metric.USER_HOME, collectMetrics); 
         Analytics.trackDomain(Metric.DOMAIN, collectMetrics);
-        Analytics.track(Metric.ZINGG_VERSION, "0.4.1-SNAPSHOT", collectMetrics);
         Analytics.postEvent(zinggOption.getName(), collectMetrics);
 	}
 

diff --git a/common/core/src/main/java/zingg/common/core/util/Analytics.java b/common/core/src/main/java/zingg/common/core/util/Analytics.java
@@ -50,7 +50,9 @@ public static void track(String metricName, String metricValue, boolean collectM
 	public static void trackEnvProp(String metricName, boolean collectMetrics) {
 		if (collectMetrics) {
 			try{
-				getMetrics().put(metricName, System.getProperty(metricName));
+				if (System.getProperty(metricName) != null) {
+					getMetrics().put(metricName, "true");
+				}
 			}
 			catch(Exception e){
 				getMetrics().put(metricName, "Exception " + e.getMessage());

diff --git a/common/pom.xml b/common/pom.xml
@@ -10,7 +10,7 @@
 	<packaging>pom</packaging>
 	<modules>
 		<module>infra</module>
-		<module>core</module>
 		<module>client</module>
+		<module>core</module>
 	</modules>
 </project>