[WIP][DO NOT MERGE] Draft implementation of the new PySpark API for support of both Spark Classic and Spark Connect #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extend using IArguments
generate docs to show concise data if user so asks issue zinggAI#723
0.4.1 review comments implemented for pr code coverage
changed version to 0.4.1-SNAPSHOT
merge 0.4.1 into enterprise
…nto enterprise
refactor constructor and access level of executor methods
Update Dependencies version
…ations Annotations to Generate py codes
…ations Update the Setter functions generated code in annotations
Update Annotations to generate code
code refactoring of ClientOptions
doc changes for AWS S3
final changes
Aws s3 doc refactor 838
dupe code removed issue zinggAI#598
test that model got created in train phase issue zinggAI#783
Test refactor
On branch main Your branch is up to date with 'origin/main'. Changes to be committed: modified: common/client/src/main/java/zingg/common/client/ClientOptions.java modified: protobuf/connect_plugins.proto modified: python/zingg_v2/proto/connect_plugins_pb2.py modified: python/zingg_v2/proto/connect_plugins_pb2.pyi modified: spark/client/src/main/java/zingg/spark/connect/ZinggConnectPlugin.java modified: spark/client/src/main/java/zingg/spark/connect/proto/ConnectPlugins.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main idea is to make python part lazy. All the classes, like Argument, Pipe, etc. should be pure python classes that do not contain any interactions with JVM.
Interaction with JVM in this case should be encapsulated into 2-3 methods of the new
Clientand will contain passing the full JSON generated from python Arguments, Pipes, FieldDefintions, etc.