-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix partially #30 (only Scala 3) #278
Conversation
@y-yu |
For Scala 2 fix, I think most of the issue is contained in |
/** | ||
* Returns true if the given type contains no type parameters | ||
* (this means the type is not "weak" https://stackoverflow.com/questions/29435985/weaktypetag-v-typetag) | ||
*/ | ||
private def allPartsStrong(typeRepr: TypeRepr): Boolean = | ||
typeRepr.dealias match { | ||
case x if x.typeSymbol.isTypeParam => false | ||
case x if x.typeSymbol.isTypeParam && summonable(x) => false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to avoid implicit search here? In what situation do we need to regard a type parameter as strong if it doesn't have an implicit Tag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was trying to fix this and finally it had worked without implicit search 🎉 after merging #279. (But I don't understand why it worked... 😇 )
fc9d748
to
8bc7c06
Compare
@y-yu Thank you! 🙏 |
Union
and higher kind types for effect stacks