-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix tagFromTagMacro for scala.Array #520
base: develop
Are you sure you want to change the base?
Conversation
💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe. |
9907d09
to
c9d0b2e
Compare
izumi-reflect/izumi-reflect/src/main/scala-3/izumi/reflect/TagMacro.scala
Outdated
Show resolved
Hide resolved
Literal(ClassOfConstant(lubClassOf(intersectionUnionRefinementClassPartsOf(typeRepr)))).asExprOf[Class[?]] | ||
val arrayTypeSymbol = TypeRepr.of[Array].typeSymbol | ||
Literal( | ||
ClassOfConstant( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While it might work as a workaround, I'm not inclined to accept this, as I said previously, this is a compiler bug which should be fixed in the compiler, and as far as I'm aware there is an open P/R fixing this. The bounty should either be removed from this issue or given to the compiler developers. /cc @jdegoes
Please consider other issues with bounties.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can wait for compiler bug to resolve, or you make it work for your users and then wait for compiler bug to resolve. There is an issue with bounty and removing bounty after fix is done would be unfair
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've explained my position previously. The bounty shouldn't have been on this issue.
c9d0b2e
to
ec8fdb6
Compare
/claim #474