Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tagFromTagMacro for scala.Array #520

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

goshacodes
Copy link

/claim #474

@CLAassistant
Copy link

CLAassistant commented Feb 12, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

algora-pbc bot commented Feb 12, 2025

💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe.

Literal(ClassOfConstant(lubClassOf(intersectionUnionRefinementClassPartsOf(typeRepr)))).asExprOf[Class[?]]
val arrayTypeSymbol = TypeRepr.of[Array].typeSymbol
Literal(
ClassOfConstant(
Copy link
Member

@pshirshov pshirshov Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While it might work as a workaround, I'm not inclined to accept this, as I said previously, this is a compiler bug which should be fixed in the compiler, and as far as I'm aware there is an open P/R fixing this. The bounty should either be removed from this issue or given to the compiler developers. /cc @jdegoes

Please consider other issues with bounties.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can wait for compiler bug to resolve, or you make it work for your users and then wait for compiler bug to resolve. There is an issue with bounty and removing bounty after fix is done would be unfair

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've explained my position previously. The bounty shouldn't have been on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants