Only warn user of --local-addr
is provided explicitly by user
#489
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is a
--name-server
(either explicitly provided by user or implicit from/etc/resolv.conf
) that cannot be reached by the--local-addr
, we'll attempt to correct thelocal-addr
to reach the nameserver.In the fix in #481, I made this a
warn
msg to the user.However, this means the user is getting a warn whenever the
--local-addr
is overridden, even if it's just a default being overridden.We'll move to erroring out if the user supplies a
--local-addr
we can't use, and nowarn
otherwisemain
This PR - only
warn
if user directly supplied alocal-addr
and we override it.No
--local-addr
Supplying a
--local-addr
that we must override