Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct effective date for e_ev_extra_subject_attribs #911

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Correct effective date for e_ev_extra_subject_attribs #911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ccf4724
Correct effective date for e_ev_extra_subject_attribs
mathewhodson Jan 18, 2025
931170f
Merge branch 'master' into patch-4
christopher-henderson Jan 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions v3/integration/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -977,9 +977,6 @@
"e_subj_country_not_uppercase": {
"ErrCount": 1303
},
"e_ev_extra_subject_attribs": {
"ErrCount": 12279
},
"e_subj_contains_html_entities": {
"ErrCount": 14
}
Expand Down
10 changes: 2 additions & 8 deletions v3/lints/cabf_ev/lint_extra_subject_attribs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ func init() {
Description: "CAs SHALL NOT include any Subject Distinguished Name attributes except as specified...",
Citation: "EVGs §7.1.4.2.9",
Source: lint.CABFEVGuidelines,
EffectiveDate: util.SC16EffectiveDate,
EffectiveDate: util.CABFBRs_OU_Prohibited_Date,
},
Lint: NewExtraSubjectAttribs,
})
Expand All @@ -52,13 +52,7 @@ func (l *extraSubjectAttribs) CheckApplies(c *x509.Certificate) bool {
}

/*
* We also include the OU attribute here, even though it is now banned, because this lint
* deals with a more general requirement that came into force long before the OU ban,
* and there is already another lint that deals with the OU attribute specifically.
*
* The organizationIdentifier attribute is only permitted starting from 21-may-2019 (EVGL 1.7.0),
* which is slightly after SC16 came into force, however any certificates that contain this
* attribute and were issued before that date have long since expired, so it makes no difference.
* This list is effective from EVG 1.7.7 when SC47 came into force.
*/
var allowedAttribs = map[string]bool{
"1.3.6.1.4.1.311.60.2.1.1": true, // joiLocalityName
Expand Down
Loading