Android - Set Volume Button Controls On Android Audio Stream #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks this works great. This really deserves to be merged otherwise you can't control the volume of an app. Sometimes sounds are way to loud and unbearable. |
Merged
|
Already merged in #713 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Currently changing the audio stream via
setCategorydoes not change the volume control for Android devices. This causes the device's volume buttons to adjust volume for the wrong stream (generally the default ringer).Fix:
When setting Sound category, also set the volume control so that pressing the volume buttons has the desired effect for the RN app.
This is the behavior of apps like Youtube, Pandora, and Spotify to ensure the best user experience when playing audio.