helm: add the posibility to add external secrets as env variables

[mikkeschiren]

This small change adds the posibility to add environments variables from an external secret. Good when you want to keep secrets out of your overrides, or are using an external resource to create the environment variables.

[mikkeschiren]

I will do some more work on this, to add the possibility to add more than one secret. I will will push a change later today.

[timabbott]

What does the SECRET one do -- is the point that it's not passed into zulip-secrets, or is it? I feel like the documentation needs to be clearer about how to interpret this example.

[mikkeschiren]

Agree, I will add better example.

[timabbott]

Is it useful/necessary to have the [] here?

[mikkeschiren]

You mean the newline?

There is a mix of practice of this.

This:

  envSecrets:
    []

And this:

  envSecrets: []

Have the same meaning, but I like the first one better - because it also indicates that the values that it is entered should be on a new line:

  envSecrets:
    - secret_ONE: ERTY
    - secret_TWO: YTRE

So I think it helps the user.

But as there are mix of standards in the helm chart, like:

podSecurityContext:
  {}

And

podAnnotations: {}

There should be maybe a consensus around what should be used. I like the newline myself, as I think it helps to guide the user.

[timabbott]

Should the commits be squashed? They seem to have a bunch of fixups.

[mikkeschiren]

Will look into this in the coming week.