Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows for expose https port based on
DISABLE_HTTPS
config.The rationale is, I've tried to deploy the chart using an ingress and found it complicated to configure the proper whitelists for the proxy chain of trust. All to end up with a setup where the segment between zulip and the ingress controller passes in the clear.
With this simple modification I don't change the previous chart's behaviour but I can configure my ingress to use https eg. by annotating it in values file:
and this produce an easy to obtain end-to-end encryption and zero fights with the container setup!
How did you test this PR?
Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following:
Hope this helps, ciao and thank you!