-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/#2669 lx ly #2694
Merged
Merged
Feature/#2669 lx ly #2694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ARR552
requested review from
tclemos,
ToniRamirezM,
agnusmor and
joanestebanr
October 20, 2023 10:15
joanestebanr
added a commit
that referenced
this pull request
Nov 3, 2023
ARR552
force-pushed
the
feature/#2669_LxLy
branch
from
November 8, 2023 14:40
1eeef5b
to
4275288
Compare
ARR552
force-pushed
the
feature/#2669_LxLy
branch
from
November 8, 2023 14:44
4275288
to
7bb568e
Compare
joanestebanr
added a commit
that referenced
this pull request
Nov 9, 2023
* adapt ARR552 fixes from PR #2694 * add failfast to reduce the time on fail * fix problem with update GER * avoid duplicated code for vector_groupx
ARR552
force-pushed
the
feature/#2669_LxLy
branch
from
November 22, 2023 15:03
d8e93f1
to
2860941
Compare
agnusmor
approved these changes
Nov 23, 2023
joanestebanr
approved these changes
Nov 23, 2023
ToniRamirezM
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2669
What does this PR do?
This PR adapts the node to be compatible with the new LxLy smc
Reviewers